search

bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.
Apache License 2.0
4.07k stars 164 forks source link

Update VeriWasm version #684

Closed enjhnsn2 closed 2 years ago

enjhnsn2 commented 2 years ago

This updates lucet to use the most up-to-date version of VeriWasm that runs clean on lucet's fuzzer.

cfallin commented 2 years ago

Thanks very much @enjhnsn2 for all the work here!

cfallin commented 2 years ago

The CircleCI jobs on Linux are failing with the exceedingly cryptic error from wabt-sys:

 CMake Warning at CMakeLists.txt:158 (message):
    Error running `file` command on dummy executable

I'm looking into this a bit -- initially at least I notice that it's an old version (v0.6.1 vs latest v0.8.0) of the crate...

cfallin commented 2 years ago

Updating to latest wabt also doesn't help -- I pushed a commit to do this but got the same error: build results

I'm also unable to reproduce the error locally on Linux. Additionally it seems unlikely to be an issue with external environment of some sort (e.g. download at some URL became new version silently or somesuch) as another PR (#683) just passed CI and merged yesterday. @enjhnsn2 or @pchickey any other ideas?

pchickey commented 2 years ago

That error looks like the cmake on the builder isnt new enough. I have no idea why we didn't encounter the same error in 683, though.

cfallin commented 2 years ago

@enjhnsn2 I got a clean CI build on CircleCI with one more commit to update the Docker image to Ubuntu 20.04.... could you pull in the commit from this run? link

(I think that CircleCI keys CI status on commit hash, so if you push exactly my commit to this PR's branch, it should get a green check automatically)

enjhnsn2 commented 2 years ago

I updated with the Docker image commit and it does seem to have triggered CircleCI :+1: