search

bytecodealliance / registry

WebAssembly Registry (Warg)
Apache License 2.0
188 stars 28 forks source link

Display upload/download progress bar on the CLI #283

Open calvinrp opened 5 months ago

calvinrp commented 5 months ago

When uploading/downloading files, display a nice progress bar indicator that shows the progress.

MarinPostma commented 2 weeks ago

I'm working on that

MarinPostma commented 2 weeks ago

loosely related to that, but while implementing the progress bar for downloads I found that: https://github.com/bytecodealliance/registry/blob/main/src/commands/dependencies.rs#L50-L52

Is it intentional that download is called twice with the exact same args?

calvinrp commented 2 weeks ago

loosely related to that, but while implementing the progress bar for downloads I found that: https://github.com/bytecodealliance/registry/blob/main/src/commands/dependencies.rs#L50-L52

Is it intentional that download is called twice with the exact same args?

That looks like a mistake. This code and command for dependency resolution isn't fully being used yet.

The warg client is likely going to be replaced by the https://crates.io/crates/wkg client for most users. Not yet, but very soon. It supports both Warg and OCI registries.

MarinPostma commented 2 weeks ago

I removed the duplicate in my PR.