search

bytecodealliance / rustix

Safe Rust bindings to POSIX-ish APIs
Other
1.49k stars 161 forks source link

Changing `xdp_umem_reg` definition #1221

Open tgross35 opened 3 hours ago

tgross35 commented 3 hours ago

Linux 6.12 added a new field to xdp_umem_reg, tx_metadata_len (patch). We have a PR to add this field to libc at https://github.com/rust-lang/libc/pull/3956, and based on an informal search it seems like rustix might be about the only crate making use of this type currently. Is there any way we could add this field to libc without breaking things for rustix?

Considering this is a break in uapi I think we probably have some leeway making a breaking change on our end too, but I want to be sure it won't cause a build failure for everyone using rustix.

arctic-alpaca commented 3 hours ago

For some added context, https://github.com/bytecodealliance/rustix/pull/1061 is currently blocked on the update of xdp_umem_reg in libc.