bytecodealliance / sightglass

A benchmark suite and tool to compare different implementations of the same primitives.
Apache License 2.0
69 stars 33 forks source link

Update wasm build scripts to wasi-sdk-19 and rust 1.67 #232

Closed jlb6740 closed 1 year ago

jlb6740 commented 1 year ago

Patch updates wasm build scripts to use wasi-sdk-19 or rust 1.67 and also updates the wasm files built from those scripts. The only exception is spidermonkey which failed to build regardless of sdk version. This needs more investigation.

jlb6740 commented 1 year ago

Amazingly regex failed after upgrading to a newer version of rust due to a change in output:

     Running `target/debug/sightglass-cli benchmark --engine engines/wasmtime/libengine.so --raw --output-format csv -- benchmarks/regex/benchmark.wasm`
Error: Actual `stderr` does not match the expected `stderr`!
* Actual `stderr` is located at `stderr-1f1a1a7c163dcaf2-2151573-0.log`
* Expected `stderr` is located at `benchmarks/regex/stderr.expected`
Error: benchmark subprocess did not exit successfully
jlbirch@jlbirch-dev-20230321 22:48:41 ~/sightglass-jlb6740: more stderr-1f1a1a7c163dcaf2-2151573-0.log 
[regex] matching default.input
[regex] found 92 emails
[regex] found 5301 URIs
[regex] found 5 IPs
jlbirch@jlbirch-dev-20230321 22:48:49 ~/sightglass-jlb6740: more benchmarks/regex/stderr.expected 
[regex] matching ./default.input
[regex] found 92 emails
[regex] found 5301 URIs
[regex] found 5 IPs

So also updating the expected results file for regex.