search

bytecodealliance / sightglass

A benchmark suite and tool to compare different implementations of the same primitives.
Apache License 2.0
69 stars 33 forks source link

Add a run_all.sh deny list for benchmarks known not to work #242

Closed jlb6740 closed 1 year ago

jlb6740 commented 1 year ago

Benchmarks have breaks that go undetected. When they are found it is not always reasonable to expect that they will be fixed quickly. To prevent CI from failing from non issues, this patch adds a check for benchmarks known not to work .. i.e. https://github.com/bytecodealliance/sightglass/issues/238

jlb6740 commented 1 year ago

@fitzgen .. Hi, yes @abrown and I spoke offline about this. This was meant to be a nice to have when Ackermann was not working and a fix wasn't obvious. This was a way to acknowledge that, instead of watching CI fail. But its definitely not needed for Ackermann now. I'll close. Thanks.