bytecodealliance / sightglass

A benchmark suite and tool to compare different implementations of the same primitives.
Apache License 2.0
69 stars 33 forks source link

Log "output" path when warning about missing "expected" path #245

Closed abrown closed 1 year ago

abrown commented 1 year ago

Sightglass checks the benchmark's directory for stdout.expected and stderr.expected in order to compare these files with the actual execution output. Sightglass emits a logged warning when it cannot find the expected files to compare against. I observed warnings for spidermonkey and meshoptimizer but couldn't pick out which actual output files were theirs in the mass of *.log files. This change prints that output path in the warning. Once I looked at the output files for spidermonkey and meshoptimizer I realized there was nothing to worry about: both were 0-length files, as if the stderr stream had been opened but never written to.