search

bytecodealliance / wac

WebAssembly Composition (WAC) tooling
Apache License 2.0
118 stars 15 forks source link

miette #347 has been merged, fixing #219 #77

Open FrankReh opened 7 months ago

FrankReh commented 7 months ago

https://github.com/zkat/miette/pull/347 landed on Feb 21.

Maybe this comment can be addressed now?

https://github.com/bytecodealliance/wac/blob/d3f6be29f2629d866be4b1e476b373d7feaf77b5/crates/wac-parser/src/lexer.rs#L466-L479

peterhuene commented 7 months ago

Thanks for the suggestion!

I think the miette fix will now at least not be silent when the span is invalid, but that's not how we want it to behave for being able to convey an unexpected end-of-input (i.e. show highlight one past the last valid offset).

I'll test it out, but we'd probably need a feature request from miette if we want it to happen.

FrankReh commented 7 months ago

Thanks for taking a look. I hoped you would know if the special case could be removed straight away or if there were now something new to consider. I know your plate is full right now. I can't say I have even run your wac binary yet so can't offer help yet. Still getting my head around all the new stuff since WASI Preview 2 and the tooling the BA is providing.