search

bytecodealliance / wasi-rs

Experimental WASI API bindings for Rust
Apache License 2.0
271 stars 48 forks source link

Update to the latest WASI snapshot1 and release 0.10.3 #62

Closed npmccallum closed 2 years ago

npmccallum commented 2 years ago

The most notable change here is the addition of the sock_accept() call.

https://github.com/WebAssembly/WASI/pull/458

josephlr commented 2 years ago

This caused some breakage in the getrandom crate: https://github.com/rust-random/getrandom/issues/241

Given the changes to Error in https://github.com/bytecodealliance/wasi/pull/59, should this have been released as 0.11.0? Or is there not a policy around stability for pre-release minor versions (which would be perfectly fine).

npmccallum commented 2 years ago

@josephlr I wasn't aware there was an API break on main. I looked at the previous commits, but this wasn't obvious.

@alexcrichton Should we yank this release and push 0.11.0?

tschneidereit commented 2 years ago

We should probably yank this release, yes. Instead of doing an 0.11.0 based on main though maybe it makes sense to do an 0.10.4 that's based on 0.10.2 instead of main?

alexcrichton commented 2 years ago

I've yanked 0.10.3 and posted https://github.com/bytecodealliance/wasi/pull/63 for a bump.

josephlr commented 2 years ago

@tschneidereit I see the 0.11 release and the 0.10.3 yank. Do we also need the 0.10.4 release? I'm not sure how yanking crates works w/ Rust/Cargo.