search

bytecodealliance / wasm-micro-runtime

WebAssembly Micro Runtime (WAMR)
Apache License 2.0
4.84k stars 618 forks source link

Implement dynamic linking section loading #3720

Closed loganek closed 3 weeks ago

loganek commented 1 month ago

Also added build flags to enable dynamic linking

Please note this PR includes two extra commits:

If we could merge main to the dev/dynamic_linking it'd probably make the PR cleaner. @wenyongh could you help with that?

wenyongh commented 1 month ago

Also added build flags to enable dynamic linking

Please note this PR includes two extra commits:

If we could merge main to the dev/dynamic_linking it'd probably make the PR cleaner. @wenyongh could you help with that?

@loganek done with #3723.

lum1n0us commented 1 month ago

Shall we start to implement missing spec content?

If not starting, I am able to take them.

loganek commented 1 month ago

Shall we start to implement missing spec content?

  • import memory
  • import table
  • instantiation linking

If not starting, I am able to take them.

thanks a lot for offering a help. So I've started with the section loader as this is something we'll have to do anyway and it's probably the least controversial one. I've started experimenting with other stuff but I'd be grateful for any help; I'll reach out on zulip to discuss some details.

wenyongh commented 3 weeks ago

Could you rebase the code with main branch? A CI issue was fixed with ##3764

loganek commented 3 weeks ago

Could you rebase the code with main branch? A CI issue was fixed with ##3764

done

wenyongh commented 3 weeks ago

Could you rebase the code with main branch? A CI issue was fixed with ##3764

done

Seems not rebased? The CI still reported the same error: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10771650997/job/29868504952#step:14:118

Cloning into 'spec'...
~/work/wasm-micro-runtime/wasm-micro-runtime/tests/wamr-test-suites/workspace/spec ~/work/wasm-micro-runtime/wasm-micro-runtime/tests/wamr-test-suites/workspace
fatal: Could not parse object '48e69f394869c55b7bbe14ac963c09f4605490b6'.
wenyongh commented 3 weeks ago

Sorry that I didn't realize this PR is to merge to dev/dynamic_linking branch and some commits in main branch hadn't been merged to it yet, so the CI still reported error.

I just merged main into dev/dynamic_linking, could you rebase again?