search

bytecodealliance / wasm-tools

CLI and Rust libraries for low-level manipulation of WebAssembly modules
Apache License 2.0
1.3k stars 234 forks source link

Relicensing `wasm-tools` and this repository's crates #1637

Closed alexcrichton closed 2 months ago

alexcrichton commented 3 months ago

Relicensing wasm-tools

Hello everyone! This issue is here to serve as a checklist for relicensing the wasm-tools repository and all crates that it contains.

In other words this issue is adding two other licensing options to the crate, the Rust standard Apache-2.0 OR MIT option. Everyone who has contributed to this repository is cc'd below with a checkbox tracking their approval status.

If you approve of this license change it's requested you leave a comment along the lines of "I approve this license change" and your checkbox will be filled in by a maintainer.

Why change licenses?

The original choice of Apache-2.0 WITH LLVM-exception for this repository matches the licensing decision of Wasmtime itself and was intended to be compatible with it. Some crates in this repository, however, would like to be integrated into upstream Rust itself. For example the wasmparser and wasm-encoder crates are already part of the Rust compiler. Currently the Rust compiler has an exception which allows these crates despite not having the Rust-standard Apache-2.0 OR MIT license. The goal of this issue is to make integration in the upstream Rust compiler easier by ensuring that the license is fully compatible with Rust's existing license.

Contributors

Contributors to wasm-tools are generated with git shortlog --summary --numbered --email as of 28e96f680752c999f296e5f9d7d31a6be66112f5.

Other contributors

As you can see, we have a long list of contributors to wasm-tools. However, it's not even the entire list! Lots of other people helped us by providing small tweaks to the code, fixing grammar issues in documentation, and similar contributions. While these kinds of contributions are extremely valuable, they aren't covered by copyrights, and thus we don't require sign-off by the authors of these contributions.

We do want to use this opportunity to list everyone who contributed to wasm-tools in whichever way though, so here's the list of people we don't need sign-off from, including links to their contributions:

jbms commented 3 months ago

I approve this license change.

fibonacci1729 commented 3 months ago

I approve this license change.

MendyBerger commented 3 months ago

I approve this license change.

imikushin commented 3 months ago

I approve this license change.

peterhuene commented 3 months ago

I approve this license change.

yurydelendik commented 3 months ago

I approve this license change

tschneidereit commented 3 months ago

For external visibility: this kind of license change requires board approval, as documented in section 4 of the Bytecode Alliance's IP policy. The board discussed this back in March and granted the exception.

bakkot commented 3 months ago

I approve this license change.

dhil commented 3 months ago

I approve this license change.

itsrainy commented 3 months ago

I approve this license change.

dicej commented 3 months ago

I approve this license change.

Robbepop commented 3 months ago

I approve this license change.

nagisa commented 3 months ago

I approve this license change

elliottt commented 3 months ago

I approve this license change

ydnar commented 3 months ago

I approve this licensing change.

pchickey commented 3 months ago

I approve this license change.

juntyr commented 3 months ago

I approve this license change.

fitzgen commented 3 months ago

I approve this license change

cfallin commented 3 months ago

I approve this licensing change.

sunfishcode commented 3 months ago

I approve this license change.

bvisness commented 3 months ago

I approve this license change.

azaslavsky commented 3 months ago

I approve this license change.

On Wed, Jun 26, 2024, 13:11 Ben Visness @.***> wrote:

I approve this license change.

— Reply to this email directly, view it on GitHub https://github.com/bytecodealliance/wasm-tools/issues/1637#issuecomment-2192541929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JX6NQ5SQKPDCF4P6CKBDZJMN53AVCNFSM6AAAAABJ6OQTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGU2DCOJSHE . You are receiving this because you were mentioned.Message ID: @.***>

YaronWittenstein commented 3 months ago

I approve this license change.

On Wed, Jun 26, 2024 at 11:13 PM Alex Zaslavsky @.***> wrote:

I approve this license change.

On Wed, Jun 26, 2024, 13:11 Ben Visness @.***> wrote:

I approve this license change.

— Reply to this email directly, view it on GitHub < https://github.com/bytecodealliance/wasm-tools/issues/1637#issuecomment-2192541929>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA4JX6NQ5SQKPDCF4P6CKBDZJMN53AVCNFSM6AAAAABJ6OQTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGU2DCOJSHE>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/bytecodealliance/wasm-tools/issues/1637#issuecomment-2192544818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADN34J76PQKRRTFEIHHRNDZJMOFDAVCNFSM6AAAAABJ6OQTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGU2DIOBRHA . You are receiving this because you were mentioned.Message ID: @.***>

yoshuawuyts commented 3 months ago

I approve this license change.

lann commented 3 months ago

I approve this license change.

eqrion commented 3 months ago

I approve this license change.

abrown commented 3 months ago

I approve this license change

Liamolucko commented 3 months ago

I approve this license change.

andylizi commented 3 months ago

I approve this license change.

kateinoigakukun commented 3 months ago

I approve this license change.

maekawatoshiki commented 3 months ago

I approve this license change.

lars-t-hansen commented 3 months ago

I approve this license change.

jpages commented 3 months ago

I approve this license change.

rylev commented 3 months ago

I approve this license change.

adambratschikaye commented 3 months ago

I approve this license change

On Thu, Jun 27, 2024 at 3:09 PM Ryan Levick @.***> wrote:

I approve this license change.

— Reply to this email directly, view it on GitHub https://github.com/bytecodealliance/wasm-tools/issues/1637#issuecomment-2194654074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVTIZDY467KQDY5EN6HQ7ATZJQFITAVCNFSM6AAAAABJ6OQTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJUGY2TIMBXGQ . You are receiving this because you were mentioned.Message ID: @.***>

takikawa commented 3 months ago

I approve this license change.

silesmo commented 2 months ago

I approve this license change.

guybedford commented 2 months ago

I approve this license change.

Mossaka commented 2 months ago

I approve this license change

yowl commented 2 months ago

I approve this license change.

Jacarte commented 2 months ago

I approve this license change

alexcrichton commented 2 months ago

I reached out to darinmorrison over email and received confirmation from them.

alexcrichton commented 2 months ago

@syrusakbary, I swapped you in for @nlewycky: over email, @nlewycky indicated that you'd need to sign off on behalf of Wasmer as the copyright holder, since these contributions were done while they worked at Wasmer.

mainrs commented 2 months ago

I approve this license change.

bholley commented 2 months ago

I approve this change for the work contributed by Mozilla staff (Michael and Julian).

tschneidereit commented 2 months ago

Alex and I discussed how to handle the remaining contributions for which we don't have sign-off. Instead of waiting and hoping that eventually we might get that sign-off, we assessed the contributions in more detail than before.

The result is that there's only a single commit we still don't have sign-off for where we'd actually need it: the C/C++ bindings contributed by @TheGreatRambler.

This is a meaningful contribution, and we'd very clearly need sign-off to change the license of this code. So instead, we'll keep this code under the current license: it's not something of interest for use by Rust anyway.

The remaining commit we don't have sign-off for were contributed by @nlewycky as a Wasmer employee. A detailed look at these contributions shows that most of them are trivial in the copyright sense (not necessarily in the sense that making these contributions was trivial! Contributions often require careful debugging or investigation work, only to result in small changes that don't clear the creativeness bar copyright requires.) Those parts of the contributions that could even remotely be candidates for copyright happen to not be part of the code base as it is today.

Here's a list of the 11 commits in question, with explanations of why we don't need sign-off for them: 06e5bcc: trivial change d387165: trivial change 59f1881: trivial change 73dff98: pretty trivial, but also removed in its entirety 8bdcd81: pretty trivial, but also removed in its entirety 96a03c1: pretty trivial, but also removed in its entirety dfc6f3d: trivial change 32b68b8: trivial change, with anything marginally interesting removed in its entirety 319a2e2: removed in its entirety cb3bb10: trivial change ea17086: trivial change

TheGreatRambler commented 2 months ago

Ah, I approve this license change