search

bytecodealliance / wasmtime-dotnet

.NET embedding of Wasmtime https://bytecodealliance.github.io/wasmtime-dotnet/
Apache License 2.0
410 stars 52 forks source link

Added `ToString` method for `Mutability` struct #220

Closed martindevans closed 1 year ago

martindevans commented 1 year ago

Added ToString method for Mutability struct

martindevans commented 1 year ago

It looks like the CI test runner crashed, I'm not sure why. Tests pass locally.

peterhuene commented 1 year ago

I suspect we need to sync to https://github.com/bytecodealliance/wasmtime/pull/5683. The reason it's probably not crashing for you locally is you're using a slightly older Wasmtime library from a previous build. Cleaning your repo to redownload the latest dev build would likely show it (which is how the CI operates).

Unrelated to the crash, CI's been flaky on Windows for an unknown reason (occasionally fails to download the wasmtime tarballs from GitHub).

I'll see about getting CI fixed shortly.

peterhuene commented 1 year ago

I put up #221 to fix CI; we can merge that and then rebase this PR on top.

peterhuene commented 1 year ago

If we rebase this, I'll merge with a (mostly) green CI.

This and the other PR (#219) will go into the 7.0.0 release, unfortunately, unless you really need me to backport either to the 6.0 release which is imminent.

martindevans commented 1 year ago

Rebased onto main.

go into the 7.0.0 release

That's fine, neither are critical on my end :)