search

bytecodealliance / wasmtime-dotnet

.NET embedding of Wasmtime https://bytecodealliance.github.io/wasmtime-dotnet/
Apache License 2.0
409 stars 52 forks source link

✅enable to run unit tests in .NET 472 #309

Open fforjan opened 3 months ago

fforjan commented 3 months ago

This enables to run unit test in .Net 472.

It also fixes one issue when using .Net472 - we found it when following the steps from the Readme.MD

fforjan commented 3 months ago

Notice that build on linux only run for net80 image

While for windows, you would see:

Failed!  - Failed:    29, Passed:   160, Skipped:     2, Total:   191, Duration: 734 ms - Wasmtime.Tests.dll (net472)
Failed!  - Failed:    19, Passed:    80, Skipped:     0, Total:    99, Duration: 278 ms - Wasmtime.Tests.dll (net8.0)
jsturtevant commented 2 months ago

@fforjan could you rebase this PR? I will take a closer look afterwards

fforjan commented 2 months ago

@jsturtevant should be good now

fforjan commented 1 month ago

@jsturtevant let me know if you would like me to do anything