bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly
https://wasmtime.dev/
Apache License 2.0
15.13k stars 1.27k forks source link

Add capability (to cranelift) to generate .eh_frame #1282

Open yurydelendik opened 4 years ago

yurydelendik commented 4 years ago

This is a continuation of #53

We save .debug_frame section in wasmtime's JIT and wasm2obj. It will be nice to move this capability to the cranelift level (e.g. cranelift-faerie?).

This issue may intersect with #1181 for linux and macos platforms.

bjorn3 commented 4 years ago

e.g. cranelift-faerie?

Rather add common code to for example cranelift-module and then implement this in both cranelift-faerie and cranelift-object.

iximeow commented 4 years ago

Should I rebase https://github.com/bytecodealliance/cranelift/pull/902 against wasmtime? That PR added this feature to cranelift-faerie, though I had taken the lack of approval and your comment about cranelift-module to be a request for an approach more like #1181 (less focused on cranelift-faerie specifically)

marmistrz commented 4 years ago

Why does this issue close #1284? These two changes seem completely unrelated

bjorn3 commented 4 years ago

Cranelift recently got merged into the wasmtime repo. All issues have been migrated to the wasmtime repo, but this has renumbered all cranelift issues.

github-actions[bot] commented 4 years ago

Subscribe to Label Action

This issue or pull request has been labeled: "cranelift"

Users Subscribed to "cranelift" * @bnjbvr

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.