bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly
https://wasmtime.dev/
Apache License 2.0
15.42k stars 1.3k forks source link

Consistent argument handling between the `run` and `serve` commands #7105

Closed elliottt closed 1 year ago

elliottt commented 1 year ago

I think it'd be best if this had similar options to wasmtime run, for example --allow-precompiled, --dir, --env, and --profile. That being said I think it's also totally ok for this to be a follow-up PR too.

One thing that I think should also be done is to share the code that configures WASI, e.g. processing many of the -S options. For example in theory wasi-nn and such should all be possible to enable too. That would require some refactoring, however, so perhaps best to open an issue and/or file a follow-up PR for that.

_Originally posted by @alexcrichton in https://github.com/bytecodealliance/wasmtime/pull/7091#discussion_r1340537640_

elliottt commented 1 year ago

Fixed in #7134