alexcrichton
commented
8 months ago What are the other runtimes this passes in? If I run this in node it produces the same error as Wasmtime using an adapted script from this issue
runner.js
``` const ITERS = 1; //////////////////////////////////////////////////////////////////////////////// class TextEncoder { constructor(enc) { if (enc != "utf-8") { throw new Error("FITZGEN: unsupported encoding: " + enc); } } encode(s, n) { let buf = new Uint8Array(s.length); for (let i = 0; i < Math.min(s.length, n); i++) { buf[i] = s.charCodeAt(i); // lol } return buf; } }; class TextDecoder { constructor(enc) { if (enc != "utf-8") { throw new Error("FITZGEN: unsupported encoding: " + enc); } } decode(buf) { let buf8 = new Uint8Array(buf); let s = ""; for (let i = 0; i < buf8.length; i++) { s += String.fromCharCode(buf8[i]); // lol } return s; } }; //////////////////////////////////////////////////////////////////////////////// async function ionCompile(wasm) { let module = await WebAssembly.compile(wasm); // while (!wasmHasTier2CompilationCompleted(module)) { // sleep(1); // } // wasmDis(module); return module; } function unimplemented(name) { return function (...args) { throw new Error(name + " is unimplemented! args = " + args); } } class ProcExitError extends Error { constructor(code) { this.code = code; this.message = "Program exited with code " + code; } toString() { return "ProcExitError: " + this.message } } function trace(obj) { let proxy = {}; for (let key of Object.keys(obj)) { if (typeof obj[key] != "function") { proxy[key] = obj[key]; continue; } proxy[key] = function (...args) { console.log("TRACE: " + key + "(" + args + ")"); let ret = obj[key](...args); console.log("TRACE: -> " + ret); return ret; }; } return proxy; } //////////////////////////////////////////////////////////////////////////////// const fs = require('fs'); async function main() { let smWasm = fs.readFileSync(process.argv[2]); let smModule = await ionCompile(smWasm); for (let i = 0; i < ITERS; i++) { let args = process.argv; let mem = null; let start = null; let unread = true; let smInstance = await WebAssembly.instantiate(smModule, trace({ env: { memory: new WebAssembly.Memory({ // shared: true, initial: 8000, maximum: 16000, }), }, bench: { start: function () { start = monotonicNow() }, end: function () { let end = monotonicNow(); console.log("ITER: " + (end - start)); } }, wasi: { 'thread-spawn': function() { throw new Error('thread-spawn'); }, }, wasi_snapshot_preview1: { fd_pread: function() { throw new Error('fd_pread'); }, poll_oneoff: function(in_, out, n) { console.log(n); // throw new Error('poll_oneoff'); return 0; }, random_get: function(a, b) { while (b > 0) { (new DataView(mem.buffer)).setInt8(a, 1, true); b -= 1; a += 1; } return 0; }, args_get: function(a, b) { for (let arg of args) { (new DataView(mem.buffer)).setInt32(a, b, true); a += 4; for (let c in arg) { (new DataView(mem.buffer)).setInt8(b, arg.charCodeAt(c), true); b += 1; } (new DataView(mem.buffer)).setInt8(b, 0, true); b += 1; } return 0; }, args_sizes_get: function(a, b) { let len = 0; for (let arg of args) { len += arg.length + 1; } (new DataView(mem.buffer)).setInt32(a, args.length, true); (new DataView(mem.buffer)).setInt32(b, len, true); return 0; }, clock_res_get: function () { return 1; }, clock_time_get: function(a, b, c) { const now = Math.round(performance.now() * 1000000); (new DataView(mem.buffer)).setBigInt64(c, BigInt(now), true); return 0; }, fd_filestat_get: function() { throw new Error('fd_filestat_get'); }, fd_read: function(fd, iovecs_ptr, iovecs_len, out_ptr) { let mem8 = new Uint8Array(mem.buffer); switch (fd) { case 4: let data = os.file.readFile("/home/nick/sightglass/benchmarks/spidermonkey/default.input.md"); let k = 0; for (let i = 0; i < iovecs_len && k < data.length && unread; i++) { let ptr = (new DataView(mem.buffer)).getUint32(iovecs_ptr + i * 8, true); let len = (new DataView(mem.buffer)).getUint32(iovecs_ptr + i * 8 + 4, true); for (let j = 0; j < len && k < data.length; j++) { mem8[ptr + j] = data.charCodeAt(k++); } } unread = false; (new DataView(mem.buffer)).setUint32(out_ptr, k, true); return 0; default: return 8; } }, fd_seek: function(fd, offset, whence, out_ptr) { switch (fd) { case 4: let len = os.file.readFile("/home/nick/sightglass/benchmarks/spidermonkey/default.input.md").length; (new DataView(mem.buffer)).setBigUint64(out_ptr, BigInt(len), true); return 0; default: return 8; } }, fd_write: function(a, b, c, d) { let s = ''; let total = 0; while (c > 0) { let base = (new DataView(mem.buffer)).getInt32(b, true); let len = (new DataView(mem.buffer)).getInt32(b + 4, true); b += 8; c -= 1; while (len > 0) { let c = new Uint8Array(mem.buffer)[base] s += String.fromCharCode(c); len -= 1; base += 1; total += 1; } } //console.log("fd_write(" + a + "): " + s.trimEnd()); console.log(s.trimEnd()); (new DataView(mem.buffer)).setInt32(d, total, true); return 0; }, fd_fdstat_set_flags: function() { throw new Error('fd_fdstat_set_flags'); }, path_filestat_get: function() { throw new Error('path_filestat_get'); }, path_open: function(fd, dirflags, path_ptr, path_len, oflags, fs_rights_base, fs_rights_inheriting, fdflags, out_ptr) { let buf = new Uint8Array(path_len); let mem8 = new Uint8Array(mem.buffer); for (let i = 0; i < path_len; i++) { buf[i] = mem8[path_ptr + i]; } let path = (new TextDecoder('utf-8')).decode(buf); switch (path) { case "default.input.md": (new DataView(mem.buffer)).setInt32(out_ptr, 4, true); return 0; default: console.log('denying path_open(' + path + ')'); return 2; } }, path_remove_directory: function() { throw new Error('path_remove_directory'); }, path_unlink_file: function() { throw new Error('path_unlink_file'); }, sched_yield: function() { throw new Error('sched_yield'); }, environ_get: function() { return 0; }, environ_sizes_get: function(a, b) { (new DataView(mem.buffer)).setInt32(a, 0, true); (new DataView(mem.buffer)).setInt32(b, 0, true); return 0; }, fd_close: function(fd) { return 0; }, fd_fdstat_get: function(fd, out_ptr) { (new DataView(mem.buffer)).setInt32(out_ptr, 0); // type switch (fd) { case 3: (new DataView(mem.buffer)).setInt32(out_ptr + 4, 3, true); break; case 4: (new DataView(mem.buffer)).setInt32(out_ptr + 4, 4, true); break; default: (new DataView(mem.buffer)).setInt32(out_ptr + 4, 0, true); break; } (new DataView(mem.buffer)).setInt32(out_ptr + 8, 0, true); (new DataView(mem.buffer)).setInt32(out_ptr + 12, 0, true); (new DataView(mem.buffer)).setInt32(out_ptr + 16, 0, true); (new DataView(mem.buffer)).setInt32(out_ptr + 20, 0, true); return 0; }, fd_prestat_get: function(a, b) { // case for preopened "." if (a == 3) { // discriminant for directory (new DataView(mem.buffer)).setInt32(b, 0, true); // one entry in directory (new DataView(mem.buffer)).setInt32(b + 4, 1, true); return 0; } return 8; }, fd_prestat_dir_name: function(fd, ptr, len) { let buf = (new TextEncoder('utf-8')).encode(".", 1); let mem8 = new Uint8Array(mem.buffer); for (let i = 0; i < Math.min(buf.length, len); i++) { mem8[ptr + i] = buf[i]; } mem8[Math.min(buf.length, len)] = 0; return 0; }, proc_exit: function(code) { throw new ProcExitError(code); }, }, })); mem = smInstance.exports.memory; try { smInstance.exports._start(); } catch (e) { if ((e instanceof ProcExitError) && e.code == 0) { continue; } throw e; } } } main().catch(function (e) { console.log("====== ERROR!!! ======"); console.log(e); console.log(e.stack); }); ```If the only other runtime is WAMR (from the issue thread you linked then WAMR has been known in the past for non-spec-compliant behavior. If there are other runtimes though then the mystery will deepen.
dicej
abrown
UPDATE: The original issue was due to not specifying
-pthreadwhen building. Now the problem is that Wasmtime loops indefinitely when awasm32-wasi-threadsguest writes to stdout. See https://github.com/bytecodealliance/wasmtime/issues/7745#issuecomment-1877546864 for steps to reproduce.Original report follows:
Per https://github.com/WebAssembly/wasi-libc/issues/456#issuecomment-1866412804, a number of
wasi-sdkandwasi-libctests are currently failing when run using Wasmtime but run successfully on other runtimes. They seem to be related to thread-local storage (e.g. tests involvingerrno, which is a thread-local variable).Test Case
This file was built from https://github.com/WebAssembly/wasi-sdk/blob/main/tests/general/signals.c for
wasm32-wasi-threadsusingwasi-sdk:signals.c.-O0.wasm.tar.gz
Steps to Reproduce
First, install any recent version of Wasmtime (e.g. v16.0.0). Then:
Expected Results
The expected output is:
Actual Results
The actual output is:
Versions and Environment
Wasmtime version or commit: v16.0.0
Operating system: MacOS (but should repro on any OS)
Architecture: ARM64 (but should repro on any architecture)
Extra Info
See also https://github.com/WebAssembly/wasi-threads/pull/49, which may be related.