bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly
https://wasmtime.dev/
Apache License 2.0
15.1k stars 1.26k forks source link

Remove `>` and `>=` comparisons from IR #7835

Open Kmeakin opened 7 months ago

Kmeakin commented 7 months ago

Feature

The condition codes for performing the > and >= comparisons on integers should be removed from the Cranelift IR

Benefit

Makes the IR more strongly normalizing. At the moment, there are two equivalent ways of specifying the same computation: x > y and y < x are semantically equivalent but have different representations in the IR.

Having only one possible representation would mean fewer cases to consider when writing lowering/optimization code, and fewer tests have to be performed at runtime when legalizing/optimizing programs.

Implementation

Continue to accept the sgt, sge, ugt and uge condition codes when consuming textual IR, but convert them to their swapped forms and swap the arguments to icmp during parsing. Update legalization/optimization code to fix any codegen regressions.

Alternatives

Do nothing

fitzgen commented 7 months ago

I think this is a good idea, however we will want to additionally make sure that the InstBuilder trait continues to have >/>= methods, but just swaps operands and emits </<= instructions. This is the kind of thing we've talked about before in other contexts around simplifying the IR, but also not losing ergonomics for frontends or saddling them with undue breaking changes.

bjorn3 commented 7 months ago

For icmp_imm IntCC will have to preserve them or we would need to add ircmp_imm like we have irsub_imm.

Kmeakin commented 7 months ago

I can work on an implementation from this, but I will need to get permission from my employer before I can submit a PR

Solo-steven commented 1 month ago

Hi I would like to take this issue if possible, but I am beginner of wasmtime, so might take a while to fix it !