search

bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly
https://wasmtime.dev/
Apache License 2.0
14.82k stars 1.24k forks source link

upgrade to wasm-tools 210 #8772

Closed pchickey closed 3 weeks ago

pchickey commented 3 weeks ago

@alexcrichton I don't think that Resolve::select_world has an obvious way to work anymore - how do we select the default packageid when multiple packages can be defined? I used get(0) but this is an arbitrary choice. This comes up in the upgrade of wit-bindgen as well.

alexcrichton commented 3 weeks ago

Ah this is something I should have dealt with before publishing. There's some follow-up work to https://github.com/bytecodealliance/wasm-tools/pull/1577 to improve world selection, so let me try to get that in today to update to that. Otherwise wit_component::resolve_world_from_name is the rough equivalent of what to do but I'd like to change that too.

pchickey commented 3 weeks ago

Lets wait to upgrade until 211 is out.