search

bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly
https://wasmtime.dev/
Apache License 2.0
15.21k stars 1.28k forks source link

Initial migration to `wasmtime_test` #8789

Closed saulecabrera closed 3 months ago

saulecabrera commented 3 months ago

This commit introduces the initial migration to the wasmtime_test macro.

This change starts by migrating all the applicable func.rs integration tests and at the same time it removes all the duplicated integration tests in winch.rs.

Additionally, this change introduces a slight change to how the macro works. Inspired by https://github.com/bytecodealliance/wasmtime/pull/8622#pullrequestreview-2083046911 it defaults to including all the known configuration combinations and allows the macro user to opt-out where applicable. This makes the usage of the macro less verbose.

The intention is to follow-up with subsequent PRs to migrate the all the applicable tests.

saulecabrera commented 3 months ago

Thanks for the review @alexcrichton. Your suggestions make sense to me, I've pushed an update in https://github.com/bytecodealliance/wasmtime/pull/8789/commits/9638a94bda3cc6dfa23101b393ded52f4fd0bbdd. Let me know what you think. I also removed some redundant config.wasm_<feature> for features that are now enabled by default (e.g. reference_types).