search

bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly
https://wasmtime.dev/
Apache License 2.0
15.21k stars 1.28k forks source link

upgrade to wasm-tools 0.211.1 #8838

Closed pchickey closed 3 months ago

pchickey commented 3 months ago

Only one change I wasn't certain of, for the storage: &mut String parameter in wasmprinter: https://github.com/bytecodealliance/wasmtime/compare/pch/wasm_tools_211?expand=1#diff-4863961fda2fef6610662e23fb35b7d7c2a367032798634425f2f407e0ee932aR70

github-actions[bot] commented 3 months ago

Subscribe to Label Action

cc @fitzgen, @saulecabrera

This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "wasmtime:api", "winch" Thus the following users have been cc'd because of the following labels: * fitzgen: fuzzing * saulecabrera: winch To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file. [Learn more.](https://github.com/bytecodealliance/subscribe-to-label-action)
alexcrichton commented 3 months ago

Ok now that's something I wasn't expecting. Changing the crate dependency graph is changing -Cmetadata to the adapter which is causing the symbols to change. For now that can be fixed by rebuilding the adapters locally but I'll try to work up a fix tomorrow to frob the name section to avoid the hashes being there.

alexcrichton commented 3 months ago

After poking at this a bit more I think we may want to instead revert the inclusion of binaries in-tree -- https://github.com/bytecodealliance/wasmtime/pull/8856 -- which if that lands then this would be unblocked.