Wasmtime: Pop GC LIFO roots even when there is no GC heap

bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly

https://wasmtime.dev/

Apache License 2.0

14.82k stars 1.24k forks source link

Wasmtime: Pop GC LIFO roots even when there is no GC heap #8899

Closed fitzgen closed 7 hours ago

fitzgen commented 5 days ago

We can create and root i31refs without ever allocating a GC heap for the store, so we can't guard popping LIFO roots on the presence of a GC heap or else we risk unbounded growth of the LIFO root set.

github-actions[bot] commented 4 days ago

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types" Thus the following users have been cc'd because of the following labels: * fitzgen: wasmtime:ref-types To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file. [Learn more.](https://github.com/bytecodealliance/subscribe-to-label-action)