Various cleanups to the ABI handling code (part 1)

bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly

https://wasmtime.dev/

Apache License 2.0

15.21k stars 1.28k forks source link

Various cleanups to the ABI handling code (part 1) #8903

Closed bjorn3 closed 2 months ago

bjorn3 commented 3 months ago

These are the relatively trivial parts split out of https://github.com/bytecodealliance/wasmtime/pull/8875. Each commit is a separate improvement.

github-actions[bot] commented 3 months ago

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle" Thus the following users have been cc'd because of the following labels: * cfallin: isle * fitzgen: isle To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file. [Learn more.](https://github.com/bytecodealliance/subscribe-to-label-action)

bjorn3 commented 3 months ago

https://github.com/bytecodealliance/wasmtime/pull/8903/commits/20850f8054c255a049f00a2f037d774695c7f449 is responsible for the crash. It can be reproduced using cargo test --test wast -- Cranelift/pooling/tests/misc_testsuite/custom-page-sizes/custom-page-sizes.wast.

bjorn3 commented 3 months ago

Never mind. It actually crashes on the main branch too.

bjorn3 commented 2 months ago

Gentle ping