Open alexcrichton opened 2 days ago
cc @fitzgen @Kmeakin
@fitzgen, I'll leave this for you for when you get back as I assume you have stronger opinions on this level of changes.
cc @fitzgen
.github/subscribe-to-label.json
configuration file.
[Learn more.](https://github.com/bytecodealliance/subscribe-to-label-action)
cc @fitzgen @Kmeakin
No objections from me
I've done a bit more refactoring here with the goal of modeling the interpreter as an implementation of OpVisitor
and ExtendedOpVisitor
. This should help improve error messages and type-checking for missing operations when new ones are added.
I think that @fitzgen may be out for another week or so and I'm starting to accumulate other changes built on this, so @abrown would you be ok approving this from a "lgtm" point of view? Pulley is still under heavy development so it should be ok to break things/regress things temporarily and I'm happy to take responsibility for following-up on this with Nick when he's back.
#[cfg]
)interp.rs
outside of a macro invocation to get better native editor support (e.g. formatting, hints, etc).This is roughly intended to be perf-neutral but we don't have many automated benchmarks yet for Pulley so it's intended to profile later as well.