pulley: Fix interpreter push/pop

bytecodealliance / wasmtime

A fast and secure runtime for WebAssembly

https://wasmtime.dev/

Apache License 2.0

15.43k stars 1.31k forks source link

pulley: Fix interpreter push/pop #9644

Open alexcrichton opened 1 day ago

alexcrichton commented 1 day ago

Add stack-overflow checking to push and other decrements of sp.
Fix the up/down direction of push/pop (push goes down, pop goes up).
Fix the order of operation sin push, first decrement then write.
Move methods to Interpreter to use ControlFlow more heavily.

alexcrichton commented 1 day ago

Review-wise this is stacked on https://github.com/bytecodealliance/wasmtime/pull/9629

github-actions[bot] commented 1 day ago

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "pulley" Thus the following users have been cc'd because of the following labels: * fitzgen: pulley To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file. [Learn more.](https://github.com/bytecodealliance/subscribe-to-label-action)