Open alexcrichton opened 19 hours ago
cc @cfallin as you're also no doubt interested in this as well
cc @fitzgen
.github/subscribe-to-label.json
configuration file.
[Learn more.](https://github.com/bytecodealliance/subscribe-to-label-action)
Instead of adding a whole new instruction, would it be possible to use a UserExternalName with a reserved namespace like u32::MAX
? Or the Pulley interpreter could have a set of UserExternalName for which to call the specified host function without reserving any namespace.
This commit is an initial stab at implementing interpreter-to-host communication in Pulley. The basic problem is that Pulley needs the ability to call back into Wasmtime to implement tasks such as
memory.grow
, imported functions, etc. For native platforms this is a simplecall_indirect
operation in Cranelift but the story for Pulley must be different because it's effectively switching from interpreted code to native code.The solution I've ended up settling on looks pretty similar to native platforms but with a few important tweaks:
call_indirect_host
opcode is added to Pulley.call_indirect_host
to take an immediate of which signature is being used and cast the function pointer to the right type.ExternalName
.wasmtime-cranelift
now has Pulley-specific handling of the wasm-to-host transition where all previouscall_indirect
instructions are replaced with a call to a "backend intrinsic" which gets lowered to acall_indirect_host
.Note that most of this still isn't hooked up everywhere in Wasmtime. That means that the testing here is pretty light at this time. It'll require a fair bit more work to get everything fully integrated from Wasmtime in Pulley. This is expected to be one of the significant remaining chunks of work and should help unblock future testing (or make those diffs smaller ideally).