search

bytecodealliance / wrpc

Wasm component-native RPC framework
Other
118 stars 18 forks source link

fix(wit-bindgen-go): Add missing 'instance' key to slog statements #321

Closed joonas closed 6 days ago

joonas commented 6 days ago

While generating bindings I was greeted with a bunch of warnings about missing keys, so this adds theinstance key to the places where it was missing:

bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:639:123: slog.WarnContext arg "err" should be a string or a slog.Attr (possible missing key or value)
bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:648:109: slog.WarnContext arg "err" should be a string or a slog.Attr (possible missing key or value)
bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:655:128: slog.ErrorContext arg "err" should be a string or a slog.Attr (possible missing key or value)
bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:662:141: slog.WarnContext arg "err" should be a string or a slog.Attr (possible missing key or value)
...
rvolosatovs commented 6 days ago

Thanks!