Closed beyond-up closed 1 year ago
Hi, @beyond-up , some suggestions:
Hi, @beyond-up , some suggestions:
- Please change the PR title, refer: [BitSail-141][Connector] Support DDL sync in KuduWriter #448
- Please link the issue in your PR, once PR is merged, issue will be automatically closed, refer: [BitSail][Feature] Support sample in PrintSink. #253 and [BitSail][Docs] fix code highlight #285 (comment)
- Please add tests to make sure the connector is working properly
ok, thx!
Hi, @beyond-up , some suggestions:
- Please change the PR title, refer: [BitSail-141][Connector] Support DDL sync in KuduWriter #448
- Please link the issue in your PR, once PR is merged, issue will be automatically closed, refer: [BitSail][Feature] Support sample in PrintSink. #253 and [BitSail][Docs] fix code highlight #285 (comment)
- Please add tests to make sure the connector is working properly
I have modified, please help me review the code, thx @liuxiaocs7
Thanks for you suggestions, I hava optimized my code ,please help me review the code ! @garyli1019
Prepare a Pull Request
Title: [BitSail][Connector] Migrate rocketmq Sink connector to V1 interface
Close: #137
Motivation
Migrate rocketmq Sink connector to V1 interface and use BitSail unified streaming and batching interface
Modifications
Describe the modifications you've done.
Verifying this change
Please pick either of the following options.
[ ] This change is a trivial rework/code cleanup without any test coverage.
[ ] This change is already covered by existing tests, such as: (please describe tests, example:)
[ ] This change added tests and can be verified as follows:
(example:)
Documentation