bytedance / bitsail

BitSail is a distributed high-performance data integration engine which supports batch, streaming and incremental scenarios. BitSail is widely used to synchronize hundreds of trillions of data every day.
https://bytedance.github.io/bitsail/
Apache License 2.0
1.62k stars 331 forks source link

[BitSail-465][Test] Fix NullPointerException of testCreateGenericExecutor method #468

Open Jake-00 opened 1 year ago

Jake-00 commented 1 year ago

…nericExecutor

Prepare a Pull Request

Please change the PR title and the related issue number refer to the following description.

The above XYZ must be replaced with the actual GitHub Issue number, indicating that the current PR is used to solve the problem described in this Issue.

If you don't find an Issue that matches your changes, please Create Issue first, then commit this PR.

For more info about the contributing guide, see: Contributing Guide

Motivation

To deal with NullPointerException happening to function testCreateGenericExecutor().

Modifications

  1. The key of this problem is that "additional-files" cannot be loaded to this.transferableFiles, constructor would operate in new commit.
  2. To test setting's content is the job of GenericExecutorSettingTest, so I delete the compare of executortransferableFiles.

Describe the modifications you've done.

Verifying this change

Please pick either of the following options.

Documentation

Jake-00 commented 1 year ago

@hk-lrzy plz take a look, thx ☕

Jake-00 commented 1 year ago

hi @hk-lrzy , could you help to review this pr