search

bytedance / keyhouse

Keyhouse is a skeleton of general-purpose Key Management System written in Rust.
https://static.sched.com/hosted_files/cloudnativerustdayeu21/55/Keyhouse-Bruce-Ding-Shekyan.pdf
Apache License 2.0
163 stars 12 forks source link

Add dynamic_config test for new function #20

Closed niczy closed 2 years ago

niczy commented 2 years ago

Added two simple test for creating DynamicConfig with valid and invalid file.

niczy commented 2 years ago

@dingelish Could you take a look?

niczy commented 2 years ago

I am back! PTAL, seems now we have two more audit errors. @w93163red

w93163red commented 2 years ago

Update actix-web can fix that, but I am currently stuck... since: on actix web 4.0.0-beta9, it has dev::body type and has been removed in the official version.

This lead to the following change: https://github.com/bytedance/keyhouse/blob/main/src/control/mod.rs#L96 https://github.com/bytedance/keyhouse/blob/main/src/control/mod.rs#L100

need a new type to get the compilation pass. @dingelish Any suggestions?

dingelish commented 2 years ago

@w93163red you wanna upgrade to 4.0.0-beta9 ?

w93163red commented 2 years ago

Upgrade to 4•1•0

On Wed, Apr 20, 2022 at 19:14 Yu Ding @.***> wrote:

@w93163red https://github.com/w93163red you wanna upgrade to 4.0.0-beta9 ?

— Reply to this email directly, view it on GitHub https://github.com/bytedance/keyhouse/pull/20#issuecomment-1104540615, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXYLOFPHOZ5X4GJU56N3A3VGCFT5ANCNFSM5LSGWULA . You are receiving this because you were mentioned.Message ID: @.***>

dingelish commented 2 years ago

@w93163red i guess you mean "4.0.1". how about this: you create a branch and upgrade spire-workload and rustls, and then i'll help with actix. how do you think

w93163red commented 2 years ago

you can start from this branch: fix-cargo-audit

w93163red commented 2 years ago

I push a change on spire-workload @Ruide has released a new version, 1.2.0, which is with the latest rustls

niczy commented 2 years ago

Can I merge this PR first? the audit error exited without my change, we can fix them in a separate PR.

niczy commented 2 years ago

Fixed actix-router and spire-workload version, since they had breaking changes.

niczy commented 2 years ago

:-) All checks passed. Could you help merge it? (I don't have write access) @w93163red

w93163red commented 2 years ago

Spire-workload is done. Ruide has released a new version already

On Wed, Apr 20, 2022 at 19:26 Yu Ding @.***> wrote:

@w93163red https://github.com/w93163red i guess you mean "4.0.1". how about this: you create a branch and upgrade spire-workload and rustls, and then i'll help with actix. how do you think

— Reply to this email directly, view it on GitHub https://github.com/bytedance/keyhouse/pull/20#issuecomment-1104548952, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXYLOHQZUYKHBKEMJXQLMLVGCHCFANCNFSM5LSGWULA . You are receiving this because you were mentioned.Message ID: @.***>