bytedance / sonic-cpp

A fast JSON serializing & deserializing library, accelerated by SIMD.
Apache License 2.0
835 stars 101 forks source link

fix: fix rvalue for addmember/pushback #57

Closed liuq19 closed 1 year ago

liuq19 commented 1 year ago

AddMember/Pushback should use the rvalue argument because the value args will be moved.

codecov-commenter commented 1 year ago

Codecov Report

Merging #57 (3488eb9) into master (780c40c) will increase coverage by 0.07%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   95.04%   95.11%   +0.07%     
==========================================
  Files          22       22              
  Lines        2785     2785              
==========================================
+ Hits         2647     2649       +2     
+ Misses        138      136       -2     
Impacted Files Coverage Δ
include/sonic/dom/genericnode.h 99.63% <100.00%> (ø)
include/sonic/experiment/lazy_update.h 88.46% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

xiegx94 commented 1 year ago

Also PushBack API.

xiegx94 commented 1 year ago

LGTM