search

bytedance / sonic-cpp

A fast JSON serializing & deserializing library, accelerated by SIMD.
Apache License 2.0
835 stars 101 forks source link

fix: fix bug when parsing single unclosed string #88

Closed liuq19 closed 7 months ago

liuq19 commented 7 months ago

Main Changes

We should check the position when parsing the single unclosed string, such as "\"strings", because we added the sentinel "x\"x" after the JSON and it can result in a false positive.

xiegx94 commented 7 months ago

LGTM

codecov-commenter commented 7 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (2395791) to head (cbd3ecf). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
include/sonic/dom/parser.h 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## =========================================== - Coverage 95.77% 73.64% -22.13% =========================================== Files 21 21 Lines 2435 2436 +1 Branches 0 667 +667 =========================================== - Hits 2332 1794 -538 - Misses 103 355 +252 - Partials 0 287 +287 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.