search

bytedance / sonic

A blazingly fast JSON serializing & deserializing library
Apache License 2.0
6.71k stars 333 forks source link

ci: add performance diff test in github CI #413

Open liuq19 opened 1 year ago

liuq19 commented 1 year ago

We need add a performance diff test through the bench.py or other tools, and make it in github workflow.

sswastik02 commented 1 year ago

Hi @liuq19 ! I noticed this issue has been open for a while without any activity. I'd be interested in working on this. I'd love to contribute and help move this forward.

liuq19 commented 1 year ago

Thanks, welcome to try it ~

sswastik02 commented 1 year ago

Thank you for providing this opportunity to contribute.

We need add a performance diff test through the bench.py or other tools, and make it in github workflow.

However, it seems that the provided URL for the bench.py file does not lead to a valid GitHub file location. I have found bench.py, Just wanted to confirm if this is the one.

liuq19 commented 1 year ago

@sswastik02 yes, the file is bench.py

sswastik02 commented 11 months ago

Hey @liuq19 , I tried running the file on my system, it takes a really long time to execute, is there specific flags that i need to pass to it ? Also is the performance diff mainly for the pull requests? as in the performance diff between branches ?

liuq19 commented 2 months ago

pls provide more details, maybe capture or some logs. To make me can reproduce that