bytedance / sonic

A blazingly fast JSON serializing & deserializing library
Apache License 2.0
6.74k stars 333 forks source link

Break Change: drop ast.Node API `UnsafeArray()` and `UnsafeMap()` #498

Closed AsterDY closed 1 year ago

AsterDY commented 1 year ago

Reason: PR #464 changed the underlying storage of ast.Node, thus we can provide directly reference of it like UnsafeArray() and UnsafeMap(). For safety , we dropped these two API

codecov-commenter commented 1 year ago

Codecov Report

Merging #498 (e36a683) into main (007f4ff) will decrease coverage by 0.86%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   73.70%   72.85%   -0.86%     
==========================================
  Files          58       60       +2     
  Lines        8021     8016       -5     
==========================================
- Hits         5912     5840      -72     
- Misses       1789     1859      +70     
+ Partials      320      317       -3     
Files Changed Coverage Δ
ast/node.go 79.73% <ø> (-0.35%) :arrow_down:

... and 16 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more