Closed AsterDY closed 10 months ago
Merging #544 (62d514d) into main (de254c3) will not change coverage. The diff coverage is
100.00%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## main #544 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 69 69
Lines 10686 10686
=======================================
Hits 8368 8368
Misses 1955 1955
Partials 363 363
Files | Coverage Δ | |
---|---|---|
ast/iterator.go | 70.11% <100.00%> (+1.44%) |
:arrow_up: |
ast/node.go | 82.80% <100.00%> (-0.08%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Issue
After
Unset()
some nodes for its parent, call parent.Interface() will return errors likeunsupported type
Reason
That's because since # , sonic/ast didn't delete node memory after
Unset()
meanwhileInterface()
logic counted the actually non-exist node