Closed AsterDY closed 6 months ago
Attention: 35 lines
in your changes are missing coverage. Please review.
Comparison is base (
ec2ab23
) 78.57% compared to head (02ffc26
) 78.57%.
Files | Patch % | Lines |
---|---|---|
ast/node.go | 70.88% | 14 Missing and 9 partials :warning: |
ast/buffer.go | 86.41% | 5 Missing and 6 partials :warning: |
ast/iterator.go | 0.00% | 0 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Background
ast.Node.Unset()
will hard delete child for one node. But since #464 introduced llnked-chunk as storage, the behavior changed:Unset()
will set an empty node at the index but still count it. This inconsistency disturbs our users, although current behavior sounds more reasonable asUnset()
. Thus, we decide to be compatible with the old behavior.UnsetByIndex()
is not a behavior provided by stdslice
, we recommend users to useAdd()
andPop()
insteadFeature
Len()
andIndex()
won't count emtpy nodes, as implemenation ofsoft-delete
, which comes with overhead of index query O(N)Pop()
,Move()
API asslice-like
OP