bytedeco / javacpp-presets

The missing Java distribution of native C++ libraries
Other
2.62k stars 730 forks source link

License agreement not found for files in flycapture #1330

Open rahulmohang opened 1 year ago

rahulmohang commented 1 year ago

Hello,

The files,

https://github.com/bytedeco/javacpp-presets/blob/master/flycapture/src/gen/java/org/bytedeco/flycapture/global/FlyCapture2.java and https://github.com/bytedeco/javacpp-presets/blob/master/flycapture/src/gen/java/org/bytedeco/flycapture/global/FlyCapture2_C.java

contains the following license statement:

"// This software is the confidential and proprietary information of FLIR // Integrated Imaging Solutions, Inc. ("Confidential Information"). You // shall not disclose such Confidential Information and shall use it only in // accordance with the terms of the license agreement you entered into // with FLIR Integrated Imaging Solutions, Inc. (FLIR). // // FLIR MAKES NO REPRESENTATIONS OR WARRANTIES ABOUT THE SUITABILITY OF THE // SOFTWARE, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE // IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR // PURPOSE, OR NON-INFRINGEMENT. FLIR SHALL NOT BE LIABLE FOR ANY DAMAGES // SUFFERED BY LICENSEE AS A RESULT OF USING, MODIFYING OR DISTRIBUTING // THIS SOFTWARE OR ITS DERIVATIVES."

The license is confusing because there is no license agreement that users get in to. Can you please point to such terms of a license if it exists?

saudet commented 1 year ago

The license agreement happens when installing the SDK. We can't use these presets without the SDK. Does that answer your question? And there's this: https://github.com/bytedeco/javacpp-presets/blob/master/flycapture/src/main/java/org/bytedeco/flycapture/presets/FlyCapture2.java#L23

rahulmohang commented 1 year ago

Thank you, Samuel. I will let my team know about this and comment here.

rahulmohang commented 1 year ago

Hi @saudet,

I think that it would have been better if we could at least provide a link to the license agreement in the source code. We may close this issue for now. Thank you.

saudet commented 1 year ago

That sounds like a good idea. Please open a pull request to that effect! Thanks

rahulmohang commented 1 year ago

Ok