Closed HGuillemet closed 2 months ago
@halfeng @sbrunk
This PR can be tested using artifact fr.apteryx:pytorch-platform-gpu:2.3.1-1.5.11-SNAPSHOT
or fr.apteryx:pytorch-platform:2.3.1-1.5.11-SNAPSHOT
from maven repo https://s01.oss.sonatype.org/content/repositories/snapshots
.
@HGuillemet Your account doesn't already have permission to publish for org.bytedeco??
I don't have the secrets. Anyway PR builds don't publish.
You should be able to publish to org.bytedeco using your own account. I'm pretty sure I gave you access a long time ago.
Or maybe not, what the name of your OSSRH account?
HGuillemet
. But don't bother.
@HGuillemet Let's just merge this and fix anything broken with the upgrade to PyTorch 2.4?
I'm about to add a commit for 2.4.0 upgrade
Ok, we can do that too
Before merging, you must decide what to do with bytedeco/javacpp#766
Also to decide: whether adding the cuda dependency is a good thing or not.
An optional dependency on the presets for CUDA that only torch_cuda needs, sure, that's fine.
An optional dependency on the presets for CUDA that only torch_cuda needs, sure, that's fine.
Consider my comment on top post: the dependency will be mandatory when using CUDA. Presently, most users use their system cuda I guess, they will now have to use cuda presets.
Sure, that's fine, it's not a huge dependency
@saudet please restart the jobs that failed
Please upgrade the builds to CUDA 12.6, see commit https://github.com/bytedeco/javacpp-presets/commit/6853dc41a91cb46bc6c19484cae8f2a333cd8d7e
Pytorch uses cupti for profiling, but it's not provided by the cuda presets. Could we add it ?
Sure, feel free to give it a try
Ready for me. We can look at MPI or UCC distributed backend later if needed.
Artifacts for this PR are available on usual snapshot repository as org.bytedeco:pytorch-platform-gpu:2.4.0-1.5.11-SNAPSHOT
or org.bytedeco:pytorch-platform:2.4.0-1.5.11-SNAPSHOT
.
Included in this PR:
intrusive_ptr
, enabling transparent usage like forshared_ptr
weak_ptr
, enabling transparent usage (could be moved to JavaCPP ?)org.bytedeco.javacpp.pathsFirst
and their system cuda has same version than the cuda presets).functions
packages to main packageRemains to be done: