Simplify and clean-up javacpp.Loader

[HannesWell]

While working on the current OSGi issue in javacpp I read a lot through the javacpp.Loader and I have to admit, that it is sometimes hard to read and to understand this class. Not only because the class is very large but also because the big important methods (like findResources(), cacheResources(), ...) itself are complex monoliths that also sometimes repetitive code. For example SonarLint indicates a cognitive complexity of 141 for loadLibrary() and three other methods are close to to or above 100 while at most 15 is recommended. The exact numbers may be arguable, but those number underline my subjective impression.

Therefore I want to suggest to simplify and clean-up the javacpp.Loader in the following ways:

• split-up long monolithic methods into multiple (private) ones where suitable
• extract repetitive expressions into methods (mainly when they are used as arguments of if-statements)
• use try with resources (Exceptions while closing could be handled like other exceptions)
• use generic type arguments (for parametrized types, mainly Class<?>, even if it is only a wildcard.
• use the diamond operator where applicable, to not specific generic-type arguments unnecessarily and maybe some more minor improvements/simplifications.

If you are interested in such simplifications/clean-ups I would be happy to provide a corresponding PR.

[saudet]

There's a lot of stuff that should be refactored, sure, but refactoring even just the Loader isn't going to be as easy as it looks. In that case, we need to think about more than just the JDK, with Android being of particular importance, so we should make sure that any major effort there also takes into consideration at least Android bundles too, see https://github.com/bytedeco/javacv/issues/1117.

[saudet]

BTW, it looks like supporting Android App Bundles isn't going to be a problem. We can easily extract everything we need from JAR files at the beginning of the build with Gradle in a way that is 100% supported by Google, see https://github.com/bytedeco/javacv/issues/1117#issuecomment-982336622.