Open HGuillemet opened 1 year ago
That's intentional... What's the issue?
Sorry. I expected a vector interface for a vector of pairs. I didn't see the index argument of first
and second
.
But there is a little issue: how to map a c++ function returning a std::vector<std::pair<..>>::iterator
?
In Pytorch, this is the case of ParameterListImpl
for instance.
In the current version of the presets, you seem to use some workaround where the iterator, and the item are mapped to the same class.
It's not exactly a workaround, JavaCPP just isn't able to resolve the correspondence, but if you follow the typedefs and what not, that's what the type of the iterator ends up being.
But with additional functions used for iterating that we cannot map (increment and comparison operators).
Without them, I guess we can still iterate using ParameterListImpl.size()
and StringTensorPair.position(n)
on the StringTensorPair
returned by begin()
We could add those functions too if that's what you're looking for.
I think it would be a good thing.
And maybe also add a mapping for front
and back
to preserve the option of getting first and last item with a single call ?
Parser generates code for pairs and not for vectors for vectors of pairs. Example for
std::vector<std::pair<int, X>>
:This is due to these lines.
firstType
andsecondType
being tested here for generating the code of pairs.What about adding condition
dim == 0
line 221 ? Or maybe removing conditionindexType != null
line 355 ?