Closed HGuillemet closed 1 year ago
That logic should probably be in type()
instead. But then the returned Type
should be able to represent a function type with its arguments (or a function pointer), which requires modifying the Type
class.
Yeah, no, I think it's alright like this for now, thanks.
Do you want a PR on javacpp-presets for the corresponding fixes ?
No need to, they'll get fixed when they get updated.
This PR proposes to call
parameters
fromtemplateArguments
when a function is found in order to correctly pass its prototype.This solves two issues: the parsing of argument identifiers when present, and the resolution of namespaces.
Example:
Before, parsed as:
with the PR:
Some presets need to be adjusted to parse correctly with this PR (fixing of
std::function
parameters):No changes in other presets. Not tested: libfreenect2, chilitags,hyperscan, tensorflow, ale, ngraph, qt, skia, videoinput, tritonserver, depthai