bytedeco / sample-projects

Sample project files for JavaCPP, JavaCPP Presets, and JavaCV
219 stars 174 forks source link

Add an example code for Android #12

Closed hnvn closed 7 years ago

hnvn commented 7 years ago

This example contains an implementation of CvCameraPreview that fetches image data from physical camera, convert data to Mat, expose an interface for OpenCV processing, then render processed image data in a SurfaceView.

saudet commented 7 years ago

Looks good! Just a couple of things:

Thanks!

saudet commented 7 years ago

Thanks for your changes, let me know when you are done! Thanks

hnvn commented 7 years ago

I already finished my work for example

saudet commented 7 years ago

Ok, thank you, but could you also change the things I mention in my comment above?

hnvn commented 7 years ago

I changed something according to your mentions. You can review and tell me any still existing problems.

saudet commented 7 years ago

Great! But yes, please fix the following:

  1. Rename JavaCv-android-preview-exmaple to javacv-android-preview-example (although the other Android example also does preview, so we might want to have a better name...)
  2. Remove all the .gitignore files that are not in that directory
  3. Update the com.javacv reference to org.bytedeco.javacv

The rest looks good so, once this is done, I'll merge this! Thanks

hnvn commented 7 years ago

Done! Everything seems Ok. Please check again and tell me anything wrong.

saudet commented 7 years ago

Ok, thanks! Looks OK, just one last thing: Please remove the .gitignore file in the top directory. Feel free to use one in your project directory though.

hnvn commented 7 years ago

Done

saudet commented 7 years ago

And the directory name is a bit long. Let's settle for "javacv-android-camera-preview", would that be OK?

hnvn commented 7 years ago

It's ok now

saudet commented 7 years ago

Great! Awesome. Thank you very much