search

bytedreamer / OSDP.Net

A .NET Core control panel implementation of the Open Supervised Device Protocol(OSDP)
Apache License 2.0
47 stars 19 forks source link

Renamed Reader Number to Buzzer Number in the buzzer control dialog #143

Closed dmercer-google closed 8 months ago

dmercer-google commented 9 months ago

The dialog prompted for the "Reader" number which should have been named "Buzzer" number.

bytedreamer commented 9 months ago

Thanks for your contribution. The latest OSDP standard document identifies the field as Reader Number. I would want to have the labeling match what the standards terminology when possible. I would assume that you've found an OSDP reader that uses it for different buzzers (similar to LED). I do agree this is a better use of the field, however it would make sense to first get the official OSDP standard updated to match.