search

byteduck / duckOS

An x86 monolithic kernel and operating system written in modern C++. Comes with in-house graphical applications and command line utilities, plus ports of existing software. And yes, it runs DOOM!
GNU General Public License v3.0
618 stars 25 forks source link

[SUGGESTION] Use spaces instead of tabs #51

Closed MarcoCicognani closed 1 year ago

MarcoCicognani commented 1 year ago

Suggestion

In order to better uniform the code i suggest to move to the use of spaces, instead of tabs

byteduck commented 1 year ago

Hmm, I think it may be a little late for this. Since all the code is already written with tabs, I don't think there's any sense in going through and reformatting it all - I'm not sure if it would really make a tangible difference anyway, since people can adjust the width of the tabs in their editor to their liking.

Additionally, in my experience, using spaces leaves the possibility open for less uniformity if people have their editor set to use a different number of spaces than the rest of the project.

MarcoCicognani commented 1 year ago

Okay, I normally prefer spaces since they permit to do fine grained alignment; instead, with tabs, we must mix them

byteduck commented 1 year ago

Yeah, that does make sense. Unfortunately, I just don't think it's practical to move the entire codebase to spaces - I think we'll just stick with tabs to save the headache from reformatting the entire codebase.