Public fields in Message

bytefish / FcmSharp

Firebase Cloud Messaging (FCM) with .NET

MIT License

6 stars 7 forks source link

Public fields in Message #27

Closed Eirenarch closed 6 years ago

Eirenarch commented 6 years ago

I am sorry to be that guy but I just can't help it. Is there a reason why Notification and Data are public fields instead of properties in the Message class?https://github.com/bytefish/FcmSharp/blob/master/FcmSharp/FcmSharp/Requests/Message.cs

bytefish commented 6 years ago

Oops! 😌 No, there is no reason. I didn't notice and it should be a property of course. I will fix it and make a new release of the libary!

Thanks for bringing up the issue!

bytefish commented 6 years ago

The fields are properties now. I have released a new version 2.3.2 to NuGet containing the changes. Please reopen, if there are problems with the released version.