Sending an APNS Payload without a badge always resets the badge to 0 (Badge should be int? instead of int)

bytefish / FcmSharp

Firebase Cloud Messaging (FCM) with .NET

MIT License

6 stars 7 forks source link

Sending an APNS Payload without a badge always resets the badge to 0 (Badge should be int? instead of int) #36

Closed sir-boformer closed 6 years ago

sir-boformer commented 6 years ago

https://github.com/bytefish/FcmSharp/blob/b8a4ebaf9076d41b0c1d72b64d64d6583a65f0cf/FcmSharp/FcmSharp/Requests/Aps.cs#L16

bytefish commented 6 years ago

Thanks for reporting. Feel free to make a Pull Request, it should be an int?. 😎

sir-boformer commented 6 years ago

https://github.com/bytefish/FcmSharp/pull/37

bytefish commented 6 years ago

Good job!

I will release this fix in Version 2.6.0, but it will take a day due to work.

I will leave this Ticket open until the fix is released.

bytefish commented 6 years ago

Sorry it took so long. I released 2.6.0 to NuGet, which will resolve this bug. Thanks again! 👍

sir-boformer commented 6 years ago

Compared to other open source projects, this was pretty fast ;)

sir-boformer commented 6 years ago

@bytefish ~~Actually, it seems like version 2.6.0-alpha does not contain the change:~~

My fault. Seems like the alpha version is old and 2.6.0 is not yet published

bytefish commented 6 years ago

Correct! It is published, but indexing can take up to an hour. I thought you are not that fast with checking the package. 🤗 😳 Yes 2.6.0-alpha is old without the fix. 2.6.0 will be available within the next hours.