bytemakers / Noteslify

Your Privacy Friendly, Open Source. Alternative to EverNote.
GNU General Public License v3.0
125 stars 78 forks source link

🐛 [BUG] - LocalStorage theme value not updated when switch to different theme #250

Closed JrDevHarsh closed 1 year ago

JrDevHarsh commented 1 year ago

Description

When a user tries to switch the current theme for the first time, the localStorage doesn't update the theme value because the initial value of the theme is null.

Reproduction URL

https://github.com/JunDevHarsh/Noteslify

Reproduction steps

1. Go to 'apps/web/frontendnew'
2. Start to react app on 'localhost:3000'
3. Toggle the theme button
4. See localStorage theme value. If you switch to the dark theme then the theme value in localStorage will be null or light

Screenshots

![DESCRIPTION](LINK.png)

Logs

No response

Browsers

Chrome

OS

Windows

github-actions[bot] commented 1 year ago

Hey @JunDevHarsh, Thanks for contributing and Congrats on opening Issue :tada:

We will try to review as soon as possible and a maintainer will get back to you soon!

devarshishimpi commented 1 year ago

Hey, Thanks For Report the issue along with a PR for it!!

devarshishimpi commented 1 year ago

Fixed