Closed JrDevHarsh closed 1 year ago
@JunDevHarsh Could you complete the review steps before reviewing the PR??
Your code has changed the theme of the landing page.
Some Tips:
- Add some screen shots or a screen recording of visible changes (if any).
- Prefer single quotes (' ') over double quotes (" ") while contributing to this repository.
Your code has changed the theme of the landing page.
Some Tips:
- Add some screen shots or a screen recording of visible changes (if any).
- Prefer single quotes (' ') over double quotes (" ") while contributing to this repository.
Those changes were made to the new /frontendnew
folder, the /frontend
is deprecated now. But yes, apart from that single quotes over double quotes is a valid issue along with screenshots.
Hello there, I apologize that I didn't share a screenshot or screen recording before making a PR. Here is the screen recording of the issue that I have faced and solved it.
Before issue:
After issue:
Hello there, I apologize that I didn't share a screenshot or screen recording before making a PR. Here is the screen recording of the issue that I have faced and solved it.
Before issue:
before_bug.mp4 After issue:
after_bug.mp4
It's fine!! Found out the issue as described in the PR and issue. Thanks For Contributing Again!! 🙌🏻
Describe your changes
useLocalStorage
Screenshots - If Any (Optional)
Issue ticket number and link - If Any
Checklist before requesting a review
[x] I have performed a self-review of my code.
[x] Followed the repository's Contributing Guidelines.
[x] I ran the app and tested it locally to verify that it works as expected.
[x] I have starred the repository.
Additional Information (Optional)