Fixes for btoa, some jslint issues in crypto, custom callback url, fetching access tokens

bytespider / jsOAuth

JavaScript implimentation of the OAuth protocol. Currently supports version 1.0 (RFC5849) of the specification. Node.js & CommonJS compatible.

http://bytespider.github.com/jsOAuth/

MIT License

557 stars 109 forks source link

Fixes for btoa, some jslint issues in crypto, custom callback url, fetching access tokens #13

Closed tecywiz121 closed 13 years ago

tecywiz121 commented 13 years ago

Hey!

Here are some small fixes for various bugs I encountered while working with your library. I hadn't noticed you had made a branch with custom callbacks.

Thanks for all your work!

tecywiz121

bytespider commented 13 years ago

I've made some cherry picks from your pull-request, they are currently on edge for testing. I haven't taken the changes relating to using encodeURIComponent, I'll need to test that my method is slower than the one built in and how widely available it is on other platforms. I don't want to bulk up the code too much

bytespider commented 13 years ago

Okay, edge tested and approved. I'll add to master in the next release.