search

bytespider / jsOAuth

JavaScript implimentation of the OAuth protocol. Currently supports version 1.0 (RFC5849) of the specification. Node.js & CommonJS compatible.
http://bytespider.github.com/jsOAuth/
MIT License
556 stars 108 forks source link

1.3.6 error #39

Closed smldg closed 12 years ago

smldg commented 12 years ago

There appears to be an error introduced in 1.3.6 with the changes starting on line 291 ("//pulled this out of this.request to be accessible from not-closure context"). When I try to POST data I get the error "Cannot call method 'push' of null " thrown on line 362 where the data is being pushed into query - which isn't declared in the var at the top of the function. Declaring it there eliminates that error, but still breaks POST operations (at least when trying to post a tweet to the twitter api in my particular case) because the data is apparently never added to the request body - content-length is always 0.

I haven't been able to track down a specific fix for this, but reverting to 1.3.4 where this was still part of the request method eliminated all the problems for me.

bytespider commented 12 years ago

I've rolled back the error in 1.3.6 and will review the changes more carefully.