search

byteverse / chronos

Haskell time library focusing on performance
Other
54 stars 22 forks source link

Adds NFData instances for all types #56

Closed solomon-b closed 4 years ago

solomon-b commented 4 years ago

In reference to issue #52 this adds NFData instances for all Chronos types.

chessai commented 4 years ago

You are missing some bang patterns

rnf _ = ()

should be

rnf !_ = ()

solomon-b commented 4 years ago

Oops! I'll fixed that right now.

andrewthad commented 4 years ago

One last request: bump the version to 1.1.2 and then add a new changelog entry mentioning the NFData instances with the release date as 2020.??.??.

solomon-b commented 4 years ago

Version updated!