byteverse / chronos

Haskell time library focusing on performance
Other
54 stars 22 forks source link

`normalYearMonthLength` in `Chronos.hs` uses 30 days for February instead of 28 #67

Closed zeme-wana closed 2 years ago

zeme-wana commented 2 years ago

https://github.com/andrewthad/chronos/blob/922762f801ba07d72f82b48a8f14dc0842ab31bd/src/Chronos.hs#L842 The second number should be 28 for February, not 30.

andrewthad commented 2 years ago

Oh gosh! That’s not good. I wonder what’s broken by this. I’ll fix this the next time I’m at a computer if no one has made a PR by then.

andrewthad commented 2 years ago

Resolved by https://github.com/andrewthad/chronos/pull/72